Skip to content

Profiler ellipsis and alignment fix#4166

Merged
CoderDake merged 1 commit into
flutter:masterfrom
CoderDake:profiler-ellipses
Jun 6, 2022
Merged

Profiler ellipsis and alignment fix#4166
CoderDake merged 1 commit into
flutter:masterfrom
CoderDake:profiler-ellipses

Conversation

@CoderDake
Copy link
Copy Markdown
Contributor

@CoderDake CoderDake commented Jun 3, 2022

Fixes #2960

Demo

NOTE: I made the Source column smaller just for the demo, so it would be easier to trigger the ellipsis

z7juthkjar1rcsx0qciiocsf.mp4

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@CoderDake CoderDake marked this pull request as ready for review June 3, 2022 17:16
@CoderDake CoderDake merged commit fa14780 into flutter:master Jun 6, 2022
@CoderDake CoderDake deleted the profiler-ellipses branch June 6, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop manually truncating strings in the CPU profiler.

2 participants